Turned exercise 039 into practice #2281

jahielkomu · 2024-03-20T12:56:48Z

Addresses #2200. Turns Exercise 039 into Practice
@cuihtlauac please kindly review

divyankachaudhari · 2024-03-21T05:58:30Z

@jahielkomu I was working on the issue you've linked :) Also, you've linked Exercise 037 in the link, rather than 039.

divyankachaudhari · 2024-03-21T05:58:48Z

practice/039/answer/impl.ml

+    let rest = all_primes (a + 1) b in
+    if is_prime a then a :: rest else rest
+
+


Remove spaces at the end of files, add new line.

divyankachaudhari · 2024-03-21T05:58:59Z

practice/039/ex.ml

@@ -0,0 +1,41 @@
+


Remove space at the start and end of all files.

divyankachaudhari · 2024-03-21T06:00:21Z

practice/039/ex.ml

+module Make(Tested: Testable) : sig val v : test end = struct
+  open Tested
+
+  let is_prime_tests = "is_prime" >::: [


This question only asks for all_primes and not is_prime

divyankachaudhari · 2024-03-21T06:00:39Z

practice/039/ex.ml

+open OUnit2
+
+module type Testable = sig
+  val is_prime : int -> bool


Remove signature of is_prime.

divyankachaudhari · 2024-03-21T06:01:11Z

practice/039/work/impl.ml

@@ -0,0 +1,2 @@
+let prime_tests _ = failwith "Not yet implemented"


It should be all_primes function

jahielkomu · 2024-03-21T07:58:50Z

@jahielkomu I was working on the issue you've linked :) Also, you've linked Exercise 037 in the link, rather than 039.

Hello @divyankachaudhari , sorry I thought you were working on Issues #2278 and #2211
I thought it would be okay to join you on this one.

Thank you for pointing out the error in linkage

…eviewer

jahielkomu · 2024-03-21T08:34:09Z

Hello @divyankachaudhari
I had figured that to first assert is_prime works correctly would be important then proceed to assert all_primes.

Please I have updated the PR.
Kindly review and revert.
Thanks.

divyankachaudhari · 2024-03-25T07:35:35Z

@jahielkomu Yes, is_prime does need to work properly. But, the question asks for all_primes only. Now, a learner may implement it in any way that they want to. So, is_prime is not a part of question; hence it needn't be checked. You don't have to make test cases according to the model answer in the answer folder. You have to make it for the function you put as "Not yet Implemented" in the work folder.

jahielkomu · 2024-03-25T07:59:22Z

@jahielkomu Yes, is_prime does need to work properly. But, the question asks for all_primes only. Now, a learner may implement it in any way that they want to. So, is_primes is not a part of question, hence it needn't be checked. You don't have to make test cases according to the model answer in the answer folder. You have to make it for the function you put as "Not yet Implemented" in the work folder.

I do understand what you are saying @divyankachaudhari
Please kindly review the updates to the PR concerning ' Turning exercise 039 into Practice '
Thank you.

cuihtlauac · 2024-03-25T08:08:51Z

practice/039/ex.ml

This would be better tested if the all the numbers in the returned list are tested to be actually prime or not. Take inspiration from PR #2236.

Inline a list of primes in ex.ml

Turn the specified range into a value of type (int * bool) list

Turn that latter list into test cases, using List.map

Hello @cuihtlauac ,
I have indeed gained inspiration from PR #2236.

I however would like to say if a prime number doesn't fall in the list I inline then I may label it not prime which won't be correct because a prime can fall outside the primes I inline. I hope I understood your review correctly.

Solutions I'm thinking of:

Listing all the primes from 2 to 7920 and pattern matching on the list to generate tuples.

Checking each number directly and then generating tuples..(this would mean including a function that checks if a number is prime)

What is your say @cuihtlauac ?

@divyankachaudhari if there is anything you can point out, please do so too.

Thanks

PR #2236 is now mergved into folder 031. Take inspiration from that to test all the values in the range

cuihtlauac · 2024-03-26T16:23:03Z

@jahielkomu are you still working on this?

jahielkomu · 2024-03-26T17:11:43Z

@jahielkomu are you still working on this?

Yes @cuihtlauac I am.
I had tagged you in my previous comment hoping to pick your mind sir.

cuihtlauac

Fix end of files, none finishing with newline character

jahielkomu · 2024-03-27T23:01:19Z

Hello @cuihtlauac, I hope you are well.

I have updated the ex.ml file of practice/039 but solely to pick your mind.
I'm not very confident about these changes thus I kindly ask for your guidance.

Workflow.
-Have a function that checks if a number is prime
-Have another one that creates a list of type (int * bool) list

It is after this stage that I get a bit confused.
As I map through the the list what is supposed to happen?

jahielkomu · 2024-03-28T20:35:34Z

Hello @cuihtlauac I hope you are well.
Please review the updates to the PR.
I'm I on the right track?
Thanks

practice/039/answer/impl.ml

practice/039/ex.ml

cuihtlauac

I've fixed the PR. Thanks @jahielkomu

jahielkomu · 2024-03-29T07:29:23Z

I've fixed the PR. Thanks @jahielkomu

Thanks for the assistance @cuihtlauac .
If it is okay I would love to followup and ask, what happens if a user's input is a range above 200?

cuihtlauac · 2024-03-29T07:32:51Z

Program testing can be used to show the presence of bugs, but never to show their absence!

If the input is above 200, it's just an untested value.

jahielkomu · 2024-03-29T07:37:05Z

Program testing can be used to show the presence of bugs, but never to show their absence!

If the input is above 200, it's just an untested value.

This makes sense @cuihtlauac .
Thanks.

Are there more issues we can work on as we delve deeper into Ocaml?

Turned exercise 039 into practice

81330ce

divyankachaudhari reviewed Mar 21, 2024

View reviewed changes

practice/039/ex.ml

@@ -0,0 +1,41 @@

Copy link

Contributor

divyankachaudhari Mar 21, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space at the start and end of all files.

divyankachaudhari reviewed Mar 21, 2024

View reviewed changes

jahielkomu added 2 commits March 21, 2024 11:20

Updated the practice/039 folder to include changes suggested by the r…

22c9e88

…eviewer

Updated practice/039

fbb92b0

cuihtlauac requested changes Mar 25, 2024

View reviewed changes

cuihtlauac added the outreachy Outreachy contributions and blog posts label Mar 25, 2024

cuihtlauac requested changes Mar 27, 2024

View reviewed changes

cuihtlauac mentioned this pull request Mar 27, 2024

Turn exercices 033 to 042 into practice #2200

Open

9 tasks

Update practice/039 ex.ml

6a2e28a

jahielkomu and others added 2 commits March 28, 2024 02:03

Merge branch 'ocaml:main' into practice/039

0180a3b

Updating the checking of primes in practice/039

9121816

cuihtlauac requested changes Mar 29, 2024

View reviewed changes

practice/039/answer/impl.ml Outdated Show resolved Hide resolved

practice/039/answer/impl.ml Outdated Show resolved Hide resolved

practice/039/ex.ml Outdated Show resolved Hide resolved

cuihtlauac added 2 commits March 29, 2024 07:55

Apply suggestions from code review

b5ad232

Update practice/039/answer/impl.ml

f98c554

cuihtlauac requested changes Mar 29, 2024

View reviewed changes

practice/039/ex.ml Outdated Show resolved Hide resolved

Update practice/039/ex.ml

51df994

cuihtlauac approved these changes Mar 29, 2024

View reviewed changes

cuihtlauac merged commit 90d0675 into ocaml:main Mar 29, 2024
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turned exercise 039 into practice #2281

Turned exercise 039 into practice #2281

jahielkomu commented Mar 20, 2024 •

edited

Loading

divyankachaudhari commented Mar 21, 2024 •

edited

Loading

divyankachaudhari Mar 21, 2024

divyankachaudhari Mar 21, 2024 •

edited

Loading

divyankachaudhari Mar 21, 2024

divyankachaudhari Mar 21, 2024

divyankachaudhari Mar 21, 2024

jahielkomu commented Mar 21, 2024

jahielkomu commented Mar 21, 2024

divyankachaudhari commented Mar 25, 2024 •

edited

Loading

jahielkomu commented Mar 25, 2024 •

edited

Loading

cuihtlauac Mar 25, 2024

jahielkomu Mar 26, 2024

cuihtlauac Mar 28, 2024

cuihtlauac commented Mar 26, 2024

jahielkomu commented Mar 26, 2024

cuihtlauac left a comment

jahielkomu commented Mar 27, 2024

jahielkomu commented Mar 28, 2024 •

edited

Loading

cuihtlauac left a comment

jahielkomu commented Mar 29, 2024

cuihtlauac commented Mar 29, 2024 •

edited

Loading

jahielkomu commented Mar 29, 2024

		let rest = all_primes (a + 1) b in
		if is_prime a then a :: rest else rest

		@@ -0,0 +1,2 @@
		let prime_tests _ = failwith "Not yet implemented"

Turned exercise 039 into practice #2281

Turned exercise 039 into practice #2281

Conversation

jahielkomu commented Mar 20, 2024 • edited Loading

divyankachaudhari commented Mar 21, 2024 • edited Loading

divyankachaudhari Mar 21, 2024

Choose a reason for hiding this comment

divyankachaudhari Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

divyankachaudhari Mar 21, 2024

Choose a reason for hiding this comment

divyankachaudhari Mar 21, 2024

Choose a reason for hiding this comment

divyankachaudhari Mar 21, 2024

Choose a reason for hiding this comment

jahielkomu commented Mar 21, 2024

jahielkomu commented Mar 21, 2024

divyankachaudhari commented Mar 25, 2024 • edited Loading

jahielkomu commented Mar 25, 2024 • edited Loading

cuihtlauac Mar 25, 2024

Choose a reason for hiding this comment

jahielkomu Mar 26, 2024

Choose a reason for hiding this comment

cuihtlauac Mar 28, 2024

Choose a reason for hiding this comment

cuihtlauac commented Mar 26, 2024

jahielkomu commented Mar 26, 2024

cuihtlauac left a comment

Choose a reason for hiding this comment

jahielkomu commented Mar 27, 2024

jahielkomu commented Mar 28, 2024 • edited Loading

cuihtlauac left a comment

Choose a reason for hiding this comment

jahielkomu commented Mar 29, 2024

cuihtlauac commented Mar 29, 2024 • edited Loading

jahielkomu commented Mar 29, 2024

jahielkomu commented Mar 20, 2024 •

edited

Loading

divyankachaudhari commented Mar 21, 2024 •

edited

Loading

divyankachaudhari Mar 21, 2024 •

edited

Loading

divyankachaudhari commented Mar 25, 2024 •

edited

Loading

jahielkomu commented Mar 25, 2024 •

edited

Loading

jahielkomu commented Mar 28, 2024 •

edited

Loading

cuihtlauac commented Mar 29, 2024 •

edited

Loading