From e9ab2e43eb25be18b3fb2d8acde2a205da156a37 Mon Sep 17 00:00:00 2001 From: Sabine Schmaltz Date: Tue, 17 Jan 2023 13:15:42 +0100 Subject: [PATCH 1/2] make documentation link more obvious --- .../pages/package_overview.eml | 68 ++++++++++--------- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/src/ocamlorg_frontend/pages/package_overview.eml b/src/ocamlorg_frontend/pages/package_overview.eml index f31cb7b4e7..af2f65f67d 100644 --- a/src/ocamlorg_frontend/pages/package_overview.eml +++ b/src/ocamlorg_frontend/pages/package_overview.eml @@ -1,3 +1,32 @@ +let icon_homepage = + + + + +let icon_changelog = + + + + +let icon_license = + + + + +let icon_edit = + + + + +let side_box_link ~href ~title ~icon_html = + + <%s! icon_html %> + <%s title %> + + let render ~documentation_status ~readme @@ -64,17 +93,17 @@ Package_layout.render <% ); %> -
+
<% (match documentation_status with | `Success -> %> - + Documentation <% | `Unknown -> ( %> - + @@ -82,7 +111,7 @@ Package_layout.render Documentation status is unknown. <% ) | `Failure -> ( %> - + @@ -90,38 +119,15 @@ Package_layout.render Documentation failed to build. <% ));%> <% homepages |> List.iter (fun homepage -> %> - - - - - <%s Utils.host_of_uri homepage %> - + <%s! side_box_link ~icon_html:icon_homepage ~href:homepage ~title:(Utils.host_of_uri homepage) %> <% ); %> <% (match changes_filename with Some changes_filename -> %> - " class="flex items-center hover:text-primary-600"> - - - - Changelog - + <%s! side_box_link ~icon_html:icon_changelog ~href:(Url.package_doc package.name package.version ~page:(changes_filename ^ ".html")) ~title:"Changelog" %> <% | _ -> ()); %> <% (match license_filename with Some license_filename -> %> - " class="flex items-center hover:text-primary-600"> - - - - <%s package.license %> License - + <%s! side_box_link ~icon_html:icon_license ~href:(Url.package_doc package.name package.version ~page:(license_filename ^ ".html")) ~title:( package.license ^ " License") %> <% | _ -> ()); %> - - - - - Edit opam file - + <%s! side_box_link ~icon_html:icon_license ~href:(Url.github_opam_file package.name package.version) ~title:"Edit opam file" %>
Published
From 72783e1b872c97aa773f44db1228331f61ca9312 Mon Sep 17 00:00:00 2001 From: Sabine Schmaltz Date: Thu, 19 Jan 2023 14:16:36 +0100 Subject: [PATCH 2/2] minor style improvement --- src/ocamlorg_frontend/pages/package_overview.eml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ocamlorg_frontend/pages/package_overview.eml b/src/ocamlorg_frontend/pages/package_overview.eml index af2f65f67d..d325e10a15 100644 --- a/src/ocamlorg_frontend/pages/package_overview.eml +++ b/src/ocamlorg_frontend/pages/package_overview.eml @@ -96,7 +96,7 @@ Package_layout.render
<% (match documentation_status with | `Success -> %> - +