Consider that IPv6 is always enabled in Windows code

[MisterDA]

HAS_IPV6 is hardcoded in the build system, support in Windows has been there for a long time, so we can unconditionally use IPv6.

[xavierleroy]

It makes sense to assume that Windows supports IPv6 nowadays, I think, but @dra27 knows better.

I would suggest a more defensive change to otherlibs/unix/socket.c (see below), just because I believe in defensive coding for Unix system programming.

[MisterDA]

Done, thank you for your review. David actually warned me that you'd want to keep #elif defined(PF_UNSPEC), but I was too convinced that it had been defined everywhere since a long time ago.

[dra27]

Looking at the history, we've actually always been Winsock 2, although it was only when ocamldebug support was merged in 2008 that the "new" ws2_32 library was linked rather than the legacy wsock32.

I believe the APIs have been supported since late 1995... even I don't have a VM that old to hand (at least not one I can start-up since, ahem, Microsoft Virtual PC 2004 was superseded by the way less cool Virtual PC 2007)

[xavierleroy]

This is fine, thanks.

[xavierleroy]

Would you like to add an entry to the Changes file? Your choice.

[MisterDA]

I've added a small Changes entry. I wasn't sure if it was needed for that PR. Thank you!

[dra27]

Thanks!