Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Makefile.nt: won't stop on error #4099

Closed
vicuna opened this issue Sep 1, 2006 · 1 comment
Closed

Bug in Makefile.nt: won't stop on error #4099

vicuna opened this issue Sep 1, 2006 · 1 comment

Comments

@vicuna
Copy link

@vicuna vicuna commented Sep 1, 2006

Original bug ID: 4099
Reporter: necula
Status: closed (set by @damiendoligez on 2014-09-26T20:57:39Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.09.2
Target version: 4.02.1+dev
Category: platform support (windows, cross-compilation, etc)
Tags: patch
Monitored by: necula

Bug description

While making changes to the Win32 libraries I have noticed that the make process continues after error, making it hard to spot build failures.

The problem is in Makefile.nt, where there is code like this

for i in $(OTHERLIBRARIES); do $(MAKE) -C otherlibs/$$i install ; done

The body of the "for" should be changed to
do $(MAKE) -C otherlibs/$$i || exit $$?

This is already done in the Unix Makefile.

@vicuna
Copy link
Author

@vicuna vicuna commented Sep 26, 2014

Comment author: @damiendoligez

Fixed as suggested in branch 4.02 (commit 15357) and trunk (commit 15358).

@vicuna vicuna closed this as completed Sep 26, 2014
@vicuna vicuna added this to the 4.02.1 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant