Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynlink.crc_interfaces n'est pas bien backtrackée #4208

Closed
vicuna opened this issue Feb 15, 2007 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Feb 15, 2007

Original bug ID: 4208
Reporter: @alainfrisch
Assigned to: @mshinwell
Status: resolved (set by @mshinwell on 2017-06-09T15:17:57Z)
Resolution: duplicate
Priority: normal
Severity: minor
Category: otherlibs

Bug description

Dynlink.crc_interfaces est une référence sur une table de hash impérative. La référence ne change jamais de valeur, donc la logique de backtracking (dans loadfile_private) ne fonctionne pas.

@vicuna

This comment has been minimized.

Copy link
Author

commented Aug 6, 2012

Comment author: @xavierleroy

I've been sleeping on this PR for too long. If anyone feels strongly about it...

@vicuna

This comment has been minimized.

Copy link
Author

commented Jul 29, 2013

Comment author: @damiendoligez

Three solutions:

  1. Make a copy of the hash table, then restore it for backtrack, but that seems inefficient.
  2. Turn the hashtable into a Map.t, but that changes the API of Consistbl in a big way and implies more changes in the compiler's code.
  3. Turn the hashtable into a Map.t ref, and export functions for saving and restoring, but that's ugly.
@vicuna

This comment has been minimized.

Copy link
Author

commented May 5, 2017

Comment author: @mshinwell

Solved by #1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.