Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch implementing toplevel phrase filters #4543

Closed
vicuna opened this Issue Apr 27, 2008 · 3 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

commented Apr 27, 2008

Original bug ID: 4543
Reporter: @mjambon
Assigned to: ertai
Status: closed (set by @xavierleroy on 2010-04-29T12:31:15Z)
Resolution: fixed
Priority: normal
Severity: feature
Fixed in version: 3.11+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues

Bug description

The idea is to provide the possibility of using filters in the toplevel. This feature is crucial for a clean port of micmatch to 3.10. It works by adding a new class of filters: toplevel phrase filters.

The issue of filtering str_items in the toplevel was raised in this caml-list thread:

http://caml.inria.fr/pub/ml-archives/caml-list/2008/04/80773c9b3c6420d066c98f1a9a27f70e.en.html

So I'm sending a little patch with some sample code for testing.
It's quite simple and I hope I haven't overlooked any big issue.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 28, 2008

Comment author: ertai

Nice, I have not checked it for now but if it's ok it will be part of the next release.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 26, 2008

Comment author: @mjambon

I see that it's not included in 3.11.0+beta1.
Please take a look, it's important.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 27, 2008

Comment author: ertai

Thanks for the patch and your patience, it's now applied in the CVS (head and release311).

Moreover you've nicely and simply solved this issue by adding a new registration function. This way the user can choose the semantics.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.