Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assembly labels loop on huge generated .ml files #4869

Closed
vicuna opened this issue Sep 18, 2009 · 4 comments
Closed

assembly labels loop on huge generated .ml files #4869

vicuna opened this issue Sep 18, 2009 · 4 comments
Assignees
Labels

Comments

@vicuna
Copy link

@vicuna vicuna commented Sep 18, 2009

Original bug ID: 4869
Reporter: louis
Assigned to: @xavierleroy
Status: closed (set by @xavierleroy on 2012-09-25T18:07:21Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.1
Fixed in version: 3.13.0+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

native code generation uses a barrier at 100000 for the generation of asm labels, at least on i386 and amd64 (haven't tried others). This only happens when using ocaml on very huge generated code, but there doesn't seem to be a good reason to enforce this limitation (except, perhaps, readability of the asm); besides, ocaml doesn't complain but generates invalid assembly code.

Additional information

here is a possible patch that replaces the barrier at 100000 to max_int/2 : it's not pretty but solves the issue alright

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Dec 18, 2011

Comment author: @xavierleroy

Tentative fix in SVN trunk, commit 11887. Tested only on AMD64/Linux so far.

@vicuna
Copy link
Author

@vicuna vicuna commented Dec 18, 2011

Comment author: meurer

Confirmed to work with ARM/Linux.

@vicuna
Copy link
Author

@vicuna vicuna commented Dec 18, 2011

Comment author: meyer

I bumped on it also just few days ago at work when compiling 200K of mechanically generated OCaml code, I'll validate it today and update the issue.

Thank you for fixing this!

@vicuna
Copy link
Author

@vicuna vicuna commented Dec 20, 2011

Comment author: meyer

Indeed, I tried with the project that stopped compiling and it works flawlessly.

Sorry to keep you waited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants