Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labltk doesn't compile against Tcl/tk 8.6 (not yet releases) #5011

Closed
vicuna opened this Issue Mar 30, 2010 · 6 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

vicuna commented Mar 30, 2010

Original bug ID: 5011
Reporter: Christoph Bauer
Status: closed (set by @garrigue on 2010-04-03T11:41:42Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.2
Fixed in version: 3.12.0+dev
Category: ~DO NOT USE (was: OCaml general)
Related to: #4700

Bug description

labltk uses interp->result.

See http://www.tcl.tk/cgi-bin/tct/tip/330.html.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 1, 2010

Comment author: furuse

I've never tried to compile it with 8.6 but I found in 8.5:

/*
 * Note: the first three fields must match exactly the fields in a
 * Tcl_Interp struct (see tcl.h). If you change one, be sure to change the
 * other.
 *
 * The interpreter's result is held in both the string and the
 * objResultPtr fields. These fields hold, respectively, the result's
 * string or object value. The interpreter's result is always in the
 * result field if that is non-empty, otherwise it is in objResultPtr.
 * The two fields are kept consistent unless some C code sets
 * interp->result directly. Programs should not access result and
 * objResultPtr directly; instead, they should always get and set the
 * result using procedures such as Tcl_SetObjResult, Tcl_GetObjResult, and
 * Tcl_GetStringResult. See the SetResult man page for details.
 */

So the solution is to use Tcl_GetStringResult.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 2, 2010

Comment author: furuse

I have fixed the source to fix the problem. Can I commit it to the developer svn or attach the patch here ?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 2, 2010

Comment author: furuse

Attached a patch. It includes small fixes to remove warnings and removal of tkanim, which is discussed in the issue 4700.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 2, 2010

Comment author: @xavierleroy

The patch looks good even though I don't know anything about TCL/TK :-) Feel free to commit in the SVN trunk. Thanks.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 3, 2010

Comment author: furuse

Patch committed to the trunk. Could you close this?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 3, 2010

Comment author: @garrigue

Fixed by Jun Furuse on 2010-04-02.

@vicuna vicuna closed this Apr 3, 2010

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.