Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inf-caml.el globally overwrites comint-output-filter-function #5016

Closed
vicuna opened this Issue Apr 3, 2010 · 1 comment

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

commented Apr 3, 2010

Original bug ID: 5016
Reporter: diekhans
Assigned to: @diremy
Status: closed (set by @xavierleroy on 2011-05-29T10:19:32Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 3.11.2
Fixed in version: 3.12.0+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

inferior-caml-mode-output-hook in inf-caml.el globally overwrite the value of
comint-output-filter-function for all comint buffers, not just the inferior-caml-mode
buffer.

This can result in passwords in shell mode being exposed, hence the severity of major.

A patch is attached

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 27, 2010

Comment author: @diremy

The proposed patch would have the global effect of making comint-output-filter-functions buffer-local, thus
changing its behavior for other modes. This is unecessary,
since comint-output-filter-functions can be set locally with set-variable
function.

@vicuna vicuna closed this May 29, 2011

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.