Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camlp4 raises Not_found exception when DELETE_RULE fails #5119

Closed
vicuna opened this issue Aug 3, 2010 · 1 comment
Closed

camlp4 raises Not_found exception when DELETE_RULE fails #5119

vicuna opened this issue Aug 3, 2010 · 1 comment
Milestone

Comments

@vicuna
Copy link

@vicuna vicuna commented Aug 3, 2010

Original bug ID: 5119
Reporter: @ygrek
Assigned to: @xclerc
Status: closed (set by @xavierleroy on 2015-12-11T18:20:04Z)
Resolution: fixed
Priority: normal
Severity: tweak
Version: 3.12.0
Target version: 4.01.0+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Related to: #6062

Bug description

Camlp4 should raise less generic exception. Patch attached. This will of course break various extensions out there (e.g. which use DELETE_RULE to decide which syntax is currently used), but the breakage is easy to fix and will manifest itself clearly.

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Oct 25, 2012

Comment author: @xclerc

Fixed by revision 13047 in trunk.

@vicuna vicuna closed this Dec 11, 2015
@vicuna vicuna added the camlp4 label Mar 14, 2019
@vicuna vicuna added this to the 4.01.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant