Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge common floating point constants in ocamlopt #5181

Closed
vicuna opened this issue Nov 27, 2010 · 1 comment
Closed

Merge common floating point constants in ocamlopt #5181

vicuna opened this issue Nov 27, 2010 · 1 comment
Labels
Milestone

Comments

@vicuna
Copy link

@vicuna vicuna commented Nov 27, 2010

Original bug ID: 5181
Reporter: meurer
Assigned to: meurer
Status: closed (set by meurer on 2012-12-21T18:34:32Z)
Resolution: fixed
Priority: normal
Severity: tweak
Version: 3.12.0
Target version: 4.01.0+dev
Fixed in version: 4.01.0+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @hcarty @Chris00

Bug description

ocamlopt generates a unique quadword constant for every floating point constant within a function. The attached patch merges common floating point constants for the amd64 and i386 target (other ports can use a similar trick, of course, but I don't have the hardware to test, nor the knowledge to be sure there are no other constraints on the floating point constants).

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Dec 9, 2010

Comment author: meurer

New patch, which merges floating-point constants for i386/amd64 per-module instead of per-function.

@vicuna vicuna closed this Dec 21, 2012
@vicuna vicuna added this to the 4.01.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant