Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type applications in quotations #5231

Closed
vicuna opened this issue Feb 26, 2011 · 2 comments
Closed

type applications in quotations #5231

vicuna opened this issue Feb 26, 2011 · 2 comments
Assignees

Comments

@vicuna
Copy link

@vicuna vicuna commented Feb 26, 2011

Original bug ID: 5231
Reporter: @ygrek
Assigned to: @diml
Status: closed (set by @xavierleroy on 2013-08-31T10:44:07Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 3.12.1+dev
Fixed in version: 3.12.1+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Related to: #5104

Bug description

can't reopen #5104

$ /opt/ocaml-3.12+svn/bin/camlp4of -str '<:str_item< type t = $x$ >>'
Ast.StSem (_loc,
(Ast.StTyp (_loc, (Ast.TyDcl (_loc, "t", [], (Ast.TySum (_loc, x)), [])))),
(Ast.StNil _loc))

$ camlp4of -str '<:str_item< type t = $x$ >>'
Ast.StSem (_loc, Ast.StTyp (_loc, Ast.TyDcl (_loc, "t", [], x, [])),
Ast.StNil _loc)

3.12+svn is r10964

@vicuna
Copy link
Author

@vicuna vicuna commented Feb 26, 2011

Comment author: @ygrek

Maybe it makes sense to simply forbid writing quotations in original syntax at all? There have been for a long time subtle bugs with it and I follow a rule myself to always use revised syntax for quotations (right now workarounded this issue in deriving by switching to revised too).

@vicuna
Copy link
Author

@vicuna vicuna commented Jan 5, 2012

Comment author: @diml

Fixed.

Commits 11989 and 11990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants