Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse errors reported by toplevel for code of section 1.8 #5261

Closed
vicuna opened this issue May 2, 2011 · 6 comments
Closed

Parse errors reported by toplevel for code of section 1.8 #5261

vicuna opened this issue May 2, 2011 · 6 comments

Comments

@vicuna
Copy link

@vicuna vicuna commented May 2, 2011

Original bug ID: 5261
Reporter: @rixed
Status: closed (set by @xavierleroy on 2013-08-31T10:46:33Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.12.0
Category: documentation
Has duplicate: #4833 #5132
Related to: #5496 #5497
Parent of: #5264

Bug description

In section 1.8 (Pretty-printing and parsing), the code samples result in various toplevel errors.
According to Rémi Vanicat's message on ocaml_beginners ML of the 02 May 2011:

" The first problem is a lacking #load "dynlink.cma";; before
the #load "camlp4o.cma";; Then there is an encoding problem: the ' in
parser should be the ' char and not the ??? char. "

@vicuna
Copy link
Author

@vicuna vicuna commented May 2, 2011

Comment author: @damiendoligez

Are you sure about the encoding problem? Just adding the missing #load seems to fix the problem here.

@vicuna
Copy link
Author

@vicuna vicuna commented May 2, 2011

Comment author: @rixed

No, I'm not. Looking at it again I cannot find any encoding problem. I'm reporting your question to Rémi on the beginners list; feel free to close the bug if it's fixed after the #load, and I will reopen it if there is an actual issue with the encoding.

@vicuna
Copy link
Author

@vicuna vicuna commented May 2, 2011

Comment author: @rixed

After another look I think I've understood the problem: apostrophes are encoded with "’", but should be "'" or even simpler "'"
Copy and pasting with forefox works as expected, but maybe some other browser might output a different character?

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 29, 2011

Comment author: @damiendoligez

#load: fixed on 2011-07-29
Please reopen if the encoding problem is real.

@vicuna
Copy link
Author

@vicuna vicuna commented Feb 1, 2012

Comment author: @damiendoligez

The encoding problem is confirmed. The example displays correctly, but when you copy and paste it to a terminal, the ' character is not an ASCII quote.

@vicuna
Copy link
Author

@vicuna vicuna commented Feb 15, 2012

Comment author: @damiendoligez

Encoding problem fixed in trunk [3.13.0] (commit 12157).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant