Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest.compare is missing and md5 doc update #5454

Closed
vicuna opened this Issue Dec 28, 2011 · 2 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

commented Dec 28, 2011

Original bug ID: 5454
Reporter: @dbuenzli
Assigned to: meyer
Status: closed (set by @xavierleroy on 2012-09-25T18:07:21Z)
Resolution: fixed
Priority: low
Severity: feature
Version: 3.12.1
Fixed in version: 3.13.0+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @dbuenzli

Bug description

Digest.compare would be nice to be able to directly give the module to Set.Make and Map.Make. Besides the doc states :

"The digests are of cryptographic quality: it is very hard, given a digest, to forge a string having that digest. The algorithm used is MD5."

The assertion is still true, however it should be mentioned that md5 is no longer secure in a malicious setting as it is vulnerable to collision attacks.

Best,

Daniel

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 29, 2011

Comment author: meyer

Hello Daniel,

Please see SVN r11973.

Thanks,
Wojciech

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 29, 2011

Comment author: @dbuenzli

That was fast. Thanks.

@vicuna vicuna closed this Sep 25, 2012

@vicuna vicuna added the feature-wish label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.