Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the test-suite... #5482

Closed
vicuna opened this issue Jan 18, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Jan 18, 2012

Original bug ID: 5482
Reporter: @glondu
Assigned to: @xclerc
Status: closed (set by @xavierleroy on 2013-08-31T10:44:27Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.13.0+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: mehdi

Bug description

The test-suite currently (r12043) doesn't work on Debian because:

  • it uses a bashism (and on Debian (and Ubuntu), /bin/sh is not bash)
  • there are missing (empty) reference files
  • a reference file doesn't match the actual output

Attached are patches that fix that. I'm not sure if the last point is expected, though.

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented Jan 18, 2012

Comment author: @protz

Xavier, could you mention which revision this was fixed in? Did you integrate the patch? I was unable to find out which one of your latest commits fixes this :)

Thanks,

jonathan

@vicuna

This comment has been minimized.

Copy link
Author

commented Jan 18, 2012

Comment author: @glondu

The testsuite results have been fixed, but not the bashism...

@vicuna

This comment has been minimized.

Copy link
Author

commented Jan 19, 2012

Comment author: @xclerc

My bad, I thought one would run the testsuite with "SHELL=/bin/bash"
(this is what I used on Debian). Moreover, I suspect other bashisms in
the various Makefile.

For the record, the report is resolved in the trunk as of revision 12054.

@vicuna vicuna closed this Aug 31, 2013

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.