Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating of object ids in intern.c is broken #5610

Closed
vicuna opened this issue May 8, 2012 · 1 comment
Closed

Updating of object ids in intern.c is broken #5610

vicuna opened this issue May 8, 2012 · 1 comment

Comments

@vicuna
Copy link

@vicuna vicuna commented May 8, 2012

Original bug ID: 5610
Reporter: @garrigue
Assigned to: meyer
Status: closed (set by @xavierleroy on 2015-12-11T18:04:35Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 4.01.0+dev
Fixed in version: 4.00.0+dev
Category: runtime system and C interface

Bug description

Object ids are unchanged after deserialization.
The code changed a lots from the original recursive function, and I have a hard time understanding what it does...

Steps to reproduce

The tests are at the end of testsuite/tests/typing-objects/Tests.ml

cd testsuite; make one DIR=tests/typing-objects

(Maybe they would be better somewhere else, since this is a runtime issue)

@vicuna
Copy link
Author

@vicuna vicuna commented May 8, 2012

Comment author: @xavierleroy

Fixed in 4.00 branch (r12441) and in trunk (r12442). Added some more tests in testsuite/tests/lib-marshal/. Feel free to add more marshaling tests there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant