Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldoc doesn't handle module/type substitution in signatures #5645

Closed
vicuna opened this issue Jun 12, 2012 · 2 comments
Closed

ocamldoc doesn't handle module/type substitution in signatures #5645

vicuna opened this issue Jun 12, 2012 · 2 comments

Comments

@vicuna
Copy link

@vicuna vicuna commented Jun 12, 2012

Original bug ID: 5645
Reporter: ysulsky
Assigned to: @zoggy
Status: closed (set by @zoggy on 2012-06-21T05:48:59Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: ocamldoc

Bug description

Hi, it looks like ocamldoc doesn't handle module type or module substitutions in signatures.

Steps to reproduce

$ cat > z.mli
module M : sig type t end with type t := int

$ ocamldoc z.mli
The type t could not be found in the signature of module Z.M.
1 error(s) encountered

Additional information

I think the issue is that the substituted types are erased from the typed tree, but are still present in the parse tree. The attached patch removes them from the parse tree as well.

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Jun 13, 2012

Comment author: ysulsky

Oops, please use ocamldoc.type_subst.2.patch. The previous version only worked on module type declarations.

@vicuna
Copy link
Author

@vicuna vicuna commented Jun 21, 2012

Comment author: @zoggy

Thanks for the patch, applied in revision 12622 (version/4.00 branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant