Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests are failing in 4.00.0+beta2 #5648

Closed
vicuna opened this issue Jun 13, 2012 · 10 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Jun 13, 2012

Original bug ID: 5648
Reporter: @glondu
Assigned to: meyer
Status: closed (set by meyer on 2012-09-02T00:32:09Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.00.1+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: mehdi

Bug description

The following tests fail on my machine (amd64, Debian unstable):

  • lib-marshal: Uncaught exception: Invalid_argument("output_value: abstract value (outside heap)")
  • lib-threads/test1.ml: Files test1.reference and - are different
  • lib-threads/test4.ml: doesn't seem to terminate
  • lib-threads/testexit.ml: Files testexit.reference and - are different

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 18, 2012

Comment author: meyer

Hi,

Thanks.

I don't have an access to X86_64 right now, could you specify which test has failed in lib-marshal, that would help me at least assess the severity.

Wojciech

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 18, 2012

Comment author: meyer

Can you apply the patch against trunk attached and see if that fixes the problem?

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 18, 2012

Comment author: meyer

Can't reproduce it on my 64 bit host - without patch

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 18, 2012

Comment author: meyer

Hmm, looking at my patch now, I feel it's incorrect. The recursive closures will not be marshaled correctly when they are stored in a block, precisely the rest of the block after the closure will not be marshaled. So feel free to try out the patch but I don't think I can apply it.

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 19, 2012

Comment author: @glondu

I've just noticed that the lib-marshal test uses -custom. Its failure is Debian-specific (we have a special handling to avoid the strippability issue). Sorry for the noise.

However, the lib-threads tests fail even with pristine ocaml sources.

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 26, 2012

Comment author: @damiendoligez

Non-determinism in the thread semantics makes it difficult to produce a reliable test suite for threads. This needs work.

@vicuna

This comment has been minimized.

Copy link
Author

commented Jul 6, 2012

Comment author: @damiendoligez

I'd like to see the files:
testsuite/tests/lib-threads/test1.result
testsuite/tests/lib-threads/test4.result (if it exists)
testsuite/tests/lib-threads/testexit.result

Could you please upload them here?

@vicuna

This comment has been minimized.

Copy link
Author

commented Jul 17, 2012

Comment author: @damiendoligez

I found and fixed an i18n bug that probably explains your test failures. (commit 12717 in 4.00, patch included here).

If you could re-test with this patch, that would be great.

@vicuna

This comment has been minimized.

Copy link
Author

commented Jul 21, 2012

Comment author: @glondu

Indeed, you're right. All the tests pass with the patch.

@vicuna

This comment has been minimized.

Copy link
Author

commented Sep 2, 2012

Comment author: meyer

Closing, reported problem has been solved

@vicuna vicuna closed this Sep 2, 2012

@vicuna vicuna added this to the 4.00.1 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.