Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserve value as a keyword (genprintval.ml) #5677

Closed
vicuna opened this issue Jul 10, 2012 · 1 comment
Closed

reserve value as a keyword (genprintval.ml) #5677

vicuna opened this issue Jul 10, 2012 · 1 comment
Labels

Comments

@vicuna
Copy link

@vicuna vicuna commented Jul 10, 2012

Original bug ID: 5677
Reporter: @bobzhang
Status: closed (set by @damiendoligez on 2012-07-10T15:03:22Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.00.0+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

The signature in toplevel/genprintval.ml is like this:
module type EVALPATH =
sig
type value
val eval_path: Path.t -> value
exception Error
val same_value: value -> value -> bool
end
which conflicts camlp4 parser.(value is reserved as a key word). So when you want to make use of functor Genprintval.Make, conflict appears. This is not a big issue, but it may be more friendly to camlp4 if it's fixed.

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 10, 2012

Comment author: @damiendoligez

Fixed in 4.00 (commit 12689) and trunk (commit 12690).

@vicuna vicuna closed this Jul 10, 2012
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant