missing dependencies at byte-code link with mlpack

[vicuna]

Original bug ID: 5752
Reporter: @bobzhang
Status: resolved (set by @damiendoligez on 2017-02-27T12:47:35Z)
Resolution: suspended
Priority: normal
Severity: minor
Target version: later
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Duplicate of: #4592
Related to: #6326
Monitored by: @hcarty

Bug description

This problem was reported twice in caml list. I came across such a problem once again.
https://groups.google.com/forum/?fromgroups=#!searchin/fa.caml/byte$20code$20mlpack/fa.caml/c5Q8q6ZdvDw/nIFGpdVuAaUJ

Thanks

File attachments

• ex.zip

[vicuna]

Comment author: @bobzhang

this patch also worked for my case

[vicuna]

Comment author: @lefessan

I just add the patch that was proposed on the caml-list, I don't know if it correctly solves the problem (I don't use ocamlbuild...).

Index: ocamlbuild/ocaml_compiler.ml

--- ocamlbuild/ocaml_compiler.ml (revision 10605)
+++ ocamlbuild/ocaml_compiler.ml (working copy)
@@ -144,6 +144,12 @@
(if Pathname.exists (ml-.-"depends") then path_dependencies_of ml else
[])
(if Pathname.exists (mli-.-"depends") then path_dependencies_of mli
else [])
in

• let modules =
• if (modules = []) && (Pathname.exists (ml^"pack")) then

•  List.map (fun s -> (`mandatory, s)) (string_list_of_file (ml^"pack"))
  

• else

•  modules
  

• in
  if modules <> [] && not (Hashtbl.mem cache_prepare_link key) then
  let () = Hashtbl.add cache_prepare_link key true in
  let modules' = List.map (fun (_, x) -> expand_module include_dirs x
  extensions) modules in

[vicuna]

Comment author: @bobzhang

which revision?

[vicuna]

Comment author: meyer

It's been not committed, as I'm thinking of better way to do this.

[vicuna]

Comment author: @bobzhang

meyer, do you have a solution now?

[vicuna]

Comment author: nlucaroni

My group ran into this issue as well.

Another work around is to mention the missing module in the mli file that defines the mlpack. We narrowed down the root module that was causing the issue in the mlpack through the depends files. Then added an unused function in the mli file containing a type from the missing module.

[vicuna]

Comment author: Matthieu Lemerre

I also just ran into the issue.

[vicuna]

Comment author: meyer

hongboz: Looking into this at the moment

[vicuna]

Comment author: meyer

Eventually I applied the community patch in commit 13154 on trunk - because I didn't find better way.

Could anybody confirm the problem is fixed?

[vicuna]

Comment author: nlucaroni

Meyer, I'll try the patch at the end of the week. Thanks, I can understand why this solution may not be optimal --As I recall from looking at the patch, it applies to both native and byte code dependency resolution, even though the issue is only in bytecode.

I had a compilation issue with .d.byte as well, but true:debug in the _tags file with byte compilation worked perfectly fine, so I'll follow up on that as well and open a new issue if it warrants it. Thanks,

[vicuna]

Comment author: nlucaroni

I'm sorry Meyer, the patch may have fixed the issue in the case provided in the forum, but it doesn't fix the issue I've experienced. Maybe the expression of two different issues.

I compiled OCaml with svn commit revision 13167. I get the same error about a missing dependency. I first compiled the .native (worked), then the .byte (failed), then .d.byte (failed, but differently).

Let me know if there is anything I can do to help out further. I'll work on compiling the example on groups, and if that works, trying to define a small example from my source code.

[vicuna]

Comment author: nlucaroni

Yes, the example at #4592 (with an additional _tags file that was missing), fails even after this patch.

[vicuna]

Comment author: meyer

Nlucaroni, sorry to keep you waiting, ocamlbuild didn't have a proper testing infrastructure, now it has. Will have a second tour with this bug over this weekend.

Thanks for the report.

[vicuna]

Comment author: meyer

nlucaroni: Could you submit a testcase or an example that exposes the problem?

Preferably in the form of patch for testsuite, please look at ocamlbuild/testsuite/level0.ml for an example.

Thanks.

[vicuna]

Comment author: nlucaroni

I mentioned the files linked in the duplicate report [0] also fails for me. Otherwise, it's the same thing as mentioned by Ashish [1], and Grégoire Sutre [2]. I only have a large example, and busy getting a release out shortly.

0 : #4592

1 : http://caml.inria.fr/pub/ml-archives/caml-list/2008/06/784c154d0f7b53995c0167ac63fc5bb9.en.html

2 : https://groups.google.com/forum/?fromgroups=#!searchin/fa.caml/byte$20code$20mlpack/fa.caml/c5Q8q6ZdvDw/nIFGpdVuAaUJ