Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlbuild does not give correct -I flags when running menhir #5763

Closed
vicuna opened this issue Sep 21, 2012 · 4 comments
Closed

ocamlbuild does not give correct -I flags when running menhir #5763

vicuna opened this issue Sep 21, 2012 · 4 comments
Assignees

Comments

@vicuna
Copy link

@vicuna vicuna commented Sep 21, 2012

Original bug ID: 5763
Reporter: pveber
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2015-12-11T18:18:23Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 4.00.0
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Monitored by: meyer

Bug description

This bug is very similar to #4572, this time it deals with the actual parser generation instead of the dependency discovery. In both cases menhir is passed an external command (either ocamldep or ocamlc) which should have the correct options. For the parser generation, the ocamlc command (passed through the --ocamlc switch) contains a '-I ' which is good in most frequent cases but is insufficient if the parser uses types that are defined in a third-party library. In my case it is a Camlp4 AST, and when I run ocamlbuild compilation it says 'Unbound module Camlp4'

There is a more thorough description of the problem and its current workaround on the caml-list:

https://sympa.inria.fr/sympa/arc/caml-list/2012-09/msg00083.html

Additional information

The fix could be to change the function [menhir] in ocamlbuild/ocaml_tools.ml, in analogy with what is done in [menhir_modular], as the current workaround is based on [menhir_modular].

I can try to write a patch if it can help!

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Sep 21, 2012

Comment author: @gasche

The attached fix is now included in the SVN trunk (but not in the next minor release branch, so you'll have to wait a bit for the fix to propagate downstream). I would be glad if you confirmed that the attached patch indeed solves your issue.

Thanks for the report.

@vicuna
Copy link
Author

@vicuna vicuna commented Sep 22, 2012

Comment author: pveber

I confirm the patch fixes the issue. Thanks Gabriel!

@vicuna
Copy link
Author

@vicuna vicuna commented Dec 6, 2012

Comment author: jpdeplaix

I had the same bug with -package.
Is this bug will be included in 4.00.2 ?

@vicuna
Copy link
Author

@vicuna vicuna commented Jan 8, 2013

Comment author: daweil

Same for me, when I tried to use use menhir with ocamlfind and ocamlbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants