Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untypeast produces singleton tuples for constructor patterns with only one argument #5811

Closed
vicuna opened this issue Nov 6, 2012 · 3 comments
Closed
Assignees
Labels

Comments

@vicuna
Copy link

@vicuna vicuna commented Nov 6, 2012

Original bug ID: 5811
Reporter: turpin
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2015-12-11T18:19:48Z)
Resolution: fixed
Priority: low
Severity: minor
Version: 4.00.1
Fixed in version: 4.01.0+dev
Category: misc
Related to: #5728 #5729

Bug description

This can only be seen on the ast (unparsing does not show the generated tuple). I have attached the patch (trivial)

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Nov 6, 2012

Comment author: @gasche

We're starting to have reports of this kind of nonsensical-AST problems. It might be useful to have a look at the larger picture (eg. a well-structured check for ASTs that could be used to dynamically check our tools as well as user-written passes).

@vicuna
Copy link
Author

@vicuna vicuna commented Jun 14, 2013

Comment author: socrates1024

I encountered this error while following along with this blog post about type-directed syntax extensions: https://bitbucket.org/camlspotter/compiler-libs-hack
The patch solved the problem.

@vicuna
Copy link
Author

@vicuna vicuna commented Jun 17, 2013

Comment author: @alainfrisch

Thanks! Fixed as suggested on 4.01 (commit 13792) and trunk (commit 13792).

@vicuna vicuna closed this Dec 11, 2015
@vicuna vicuna added the bug label Mar 20, 2019
dra27 pushed a commit to dra27/ocaml that referenced this issue Feb 27, 2021
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.01@13792 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants