Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untypeast produces singleton tuples for constructor patterns with only one argument #5811

Closed
vicuna opened this Issue Nov 6, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

commented Nov 6, 2012

Original bug ID: 5811
Reporter: turpin
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2015-12-11T18:19:48Z)
Resolution: fixed
Priority: low
Severity: minor
Version: 4.00.1
Fixed in version: 4.01.0+dev
Category: misc
Related to: #5728 #5729

Bug description

This can only be seen on the ast (unparsing does not show the generated tuple). I have attached the patch (trivial)

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 6, 2012

Comment author: @gasche

We're starting to have reports of this kind of nonsensical-AST problems. It might be useful to have a look at the larger picture (eg. a well-structured check for ASTs that could be used to dynamically check our tools as well as user-written passes).

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2013

Comment author: socrates1024

I encountered this error while following along with this blog post about type-directed syntax extensions: https://bitbucket.org/camlspotter/compiler-libs-hack
The patch solved the problem.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 17, 2013

Comment author: @alainfrisch

Thanks! Fixed as suggested on 4.01 (commit 13792) and trunk (commit 13792).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.