Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong value of Options.ext_dll on windows #5822

Closed
vicuna opened this issue Nov 14, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Nov 14, 2012

Original bug ID: 5822
Reporter: daweil
Status: closed (set by @damiendoligez on 2015-05-12T17:34:18Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: Windows
Version: 4.00.1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.2+dev / +rc1
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Tags: patch

Bug description

Options.ext_dll has value "s.obj" instead of "dll" on windows.

I propose the following path:
--- ocaml-4.00.1/ocamlbuild/options.ml Thu Apr 26 00:17:16 2012
+++ ocaml-4.00.1_patched/ocamlbuild/options.ml Wed Nov 14 09:12:18 2012
@@ -80,7 +80,11 @@
let recursive = ref false
let ext_lib = ref Ocamlbuild_Myocamlbuild_config.a
let ext_obj = ref Ocamlbuild_Myocamlbuild_config.o
-let ext_dll = ref Ocamlbuild_Myocamlbuild_config.so
+(* let ext_dll = ref Ocamlbuild_Myocamlbuild_config.so *)
+let ext_dll =

  • let s = Ocamlbuild_Myocamlbuild_config.ext_dll in
  • ref (String.sub s 1 (String.length s - 1))

let exe = ref Ocamlbuild_Myocamlbuild_config.exe

let targets_internal = ref []

@vicuna

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Comment author: @damiendoligez

Fixed in branch 4.02 (rev 16117).

@vicuna vicuna closed this May 12, 2015

@vicuna vicuna added the ocamlbuild label Mar 14, 2019

@vicuna vicuna added this to the 4.02.2 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.