Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert failure in type checker when printing type for valid error #5865

Closed
vicuna opened this Issue Dec 26, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Dec 26, 2012

Original bug ID: 5865
Reporter: @avsm
Assigned to: @garrigue
Status: closed (set by @garrigue on 2012-12-27T02:40:08Z)
Resolution: fixed
Priority: normal
Severity: crash
Fixed in version: 4.01.0+dev
Category: typing

Bug description

With the latest OCaml 4.01.0+dev10 trunk (last commit: "do not diff the patch itself"), I get a typing assertion failure when a type error should be emitted:

File "githubbot.ml", line 19, characters 29-34:
Fatal error: exception Assert_failure("typing/printtyp.ml", 1154, 10)
Raised at file "format.ml", line 195, characters 41-52
Called from file "format.ml", line 423, characters 8-33
Called from file "format.ml", line 438, characters 6-24

The code in question is quite hard to separate out, but the failure is:

prerr_endline m.Github_t.title

where the real record field is "m.Github_t.milestone_title" instead of "title".

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Dec 27, 2012

Comment author: @garrigue

Indeed, the case where the type is known but the label name is an undefined qualified name was not handled.
Fixed in revision 13161.

@vicuna vicuna closed this Dec 27, 2012

@vicuna vicuna added the typing label Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.