Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature to Tstr_include #6073

Closed
vicuna opened this issue Jul 11, 2013 · 4 comments
Closed

Add signature to Tstr_include #6073

vicuna opened this issue Jul 11, 2013 · 4 comments
Assignees
Labels
Milestone

Comments

@vicuna
Copy link

@vicuna vicuna commented Jul 11, 2013

Original bug ID: 6073
Reporter: @lpw25
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2015-12-11T18:21:03Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.00.1
Target version: 4.01.0+dev
Fixed in version: 4.01.0+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

At the moment Tstr_include has the definition:

Tstr_include of module_expr * Ident.t list

where the second field lists the value idents defined by the include. This means that there is no way (easy) way to tell what non-value idents are defined by the include.

It would be better if it kept the full included signature (like Tsig_include does):

Tstr_include of module_expr * Types.signature

I've attached a small patch to make this change. It would be quite useful if this could be included in 4.01.0 as it will make generating documentation from .cmt files easier.

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 11, 2013

Comment author: @alainfrisch

What about using the mod_type field of the module_expr argument? (If it is a Mty_signature, you have it. Maybe it can also be a Mty_ident -- I'm not sure -- in that case you need to use Mtype.scrape on it.)

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 11, 2013

Comment author: @lpw25

I don't think the idents accessible via the mod_type field are the right ones because they get renamed before they are included.

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 17, 2013

Comment author: @alainfrisch

because they get renamed before they are included.

Indeed! I'll merge the patch.

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 17, 2013

Comment author: @alainfrisch

Commit 13903 on 4.01, 13904 on trunk.

@vicuna vicuna closed this Dec 11, 2015
@vicuna vicuna added this to the 4.01.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
dra27 pushed a commit to dra27/ocaml that referenced this issue Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants