is_inet6_addr from unix.ml should be exposed in unix.mli

[vicuna]

Original bug ID: 6105
Reporter: qrntz
Status: confirmed (set by @damiendoligez on 2013-08-28T09:16:26Z)
Resolution: open
Priority: normal
Severity: feature
Platform: i686
OS: Gentoo Linux
OS Version: Rolling release
Version: 4.00.1
Category: otherlibs
Tags: patch, junior_job

Bug description

I don't see the reasoning behind is_inet6_addr from unix.ml not being exposed in the interface; there is no other way to identify an inet_addr's address family once one has been created and while the function is fairly trivial in itself, the same code wouldn't work outside of Unix because the type abbreviation of inet_addr = string is hidden (and I would really rather not resort to type magic for something as simple as this).

There is domain_of_sockaddr that can return either PF_INET or PF_INET6 (and uses is_inet6_addr to determine that) but it's unintuitive what with being a level of abstraction higher.

File attachments

• 6105_is_inet6_addr.patch

[vicuna]

Comment author: dsheets

Patch attached.

[github-actions]

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

[nojb]

Duplicate of #4535