Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MSVC build #6181

Closed
vicuna opened this issue Sep 16, 2013 · 3 comments
Closed

Improve MSVC build #6181

vicuna opened this issue Sep 16, 2013 · 3 comments
Assignees
Milestone

Comments

@vicuna
Copy link

@vicuna vicuna commented Sep 16, 2013

Original bug ID: 6181
Reporter: chengang
Assigned to: @damiendoligez
Status: closed (set by @damiendoligez on 2014-09-28T07:48:48Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: Windows
OS: Windows
OS Version: 7+
Version: 4.01.0
Target version: 4.02.1+dev
Fixed in version: 4.02.1+dev
Category: configure and build/install
Tags: patch
Monitored by: chengang @gasche @ygrek @jmeber

Bug description

MSVC compiler option can begin with '-' or '/', i.e. "cl -nologo ..." is the same as "cl /nologo ...", usually using either works.

But in msys, it seems '/' is somehow reinterpreted, so the build will fail, but changing '/' to '-' will work.

Steps to reproduce

  1. Install VS2010 (or VS2012), msys and flexdll
  2. Start a VS2010 (or VS2012) command line
  3. Navigate to c:\msys, start msys shell
    4, In msys shell, navigate to ocaml source code folder c:\ocaml_trunk
  4. Use build process described in README.win32

The build will fail.

Apply the attached diff to source code (from SVN trunk), build again, it will work.

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Jan 21, 2014

Comment author: @damiendoligez

Need to make sure this will not break one of the other Windows ports.

@vicuna
Copy link
Author

@vicuna vicuna commented Sep 27, 2014

Comment author: @damiendoligez

Note that the compilation is intended to be done in a cygwin shell rather than an msys shell.

I'm applying this patch and CI will tell us if it breaks compilation under cygwin shell.

@vicuna
Copy link
Author

@vicuna vicuna commented Sep 28, 2014

Comment author: @damiendoligez

CI testing went well. This is fixed in 4.02 branch (commit 15362).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants