Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the tag predicate(…) isn't supposed to be used with ocamldep #6184

Closed
vicuna opened this issue Sep 19, 2013 · 1 comment
Closed

the tag predicate(…) isn't supposed to be used with ocamldep #6184

vicuna opened this issue Sep 19, 2013 · 1 comment
Assignees

Comments

@vicuna
Copy link

@vicuna vicuna commented Sep 19, 2013

Original bug ID: 6184
Reporter: jpdeplaix
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2015-12-11T18:25:56Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.01.0
Fixed in version: 4.02.0+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Tags: patch

Bug description

According to the ocamlfind manual and the following test case, « ocamlfind ocamldep » isn't supposed to handle -predicates.

Steps to reproduce

_tags:
true: predicate(test)

test.ml:
(* empty *)

$ ocamlbuild -use-ocamlfind test.ml
ocamldep: unknown option `-predicates'.

Additional information

The attached and tested patch fixes this issue.

File attachments

@vicuna
Copy link
Author

@vicuna vicuna commented Mar 20, 2014

Comment author: @gasche

Fixed in trunk (14476), with a regression test (do consider adding tests in your next patches!). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants