Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toplevel printer does not detect cycles #6228

Closed
vicuna opened this Issue Nov 7, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Nov 7, 2013

Original bug ID: 6228
Reporter: @lpw25
Assigned to: @mshinwell
Status: closed (set by @xavierleroy on 2015-12-11T18:27:43Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.01.0
Fixed in version: 4.02.0+beta1 / +rc1
Category: ~DO NOT USE (was: OCaml general)
Tags: patch
Duplicate of: #3421
Monitored by: @gasche @diml @hcarty

Bug description

The toplevel's value printer does not detect cycles in its output. This means that a simple recursive definition like:

let rec x = `Foo x

results in a one hundred line response.

Attached is a patch from Stephen Dolan which adds a check for cycles in the printer so that you instead get something like:

x = `Foo <cycle>

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Mar 26, 2014

Comment author: @lpw25

For slightly easier review I've added a pull request:

#23

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 30, 2014

Comment author: @mshinwell

This has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.