Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-DMODEL_$(MODEL) not passed when building .p.o #6268

Closed
vicuna opened this Issue Dec 13, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

vicuna commented Dec 13, 2013

Original bug ID: 6268
Reporter: plugwash
Status: closed (set by @xavierleroy on 2015-12-11T18:28:02Z)
Resolution: fixed
Priority: high
Severity: major
OS: Raspbian
OS Version: jessie
Version: 4.01.0
Target version: 4.02.0+dev
Fixed in version: 4.02.0+dev
Category: configure and build/install
Tags: patch
Monitored by: @gasche @dbuenzli

Bug description

I am one of the primary maintainers of raspbian, a project to rebuild a hard float version of debian for the raspberry pi and other armv6+vfpv2 devices. Note that while we target armv6 devices we build on armv7 devices.

The source package for ocaml 4.01.0-3 was imported from debian jessie to raspbian jessie and one of our autobuilders built it. However the binaries did not make it to the archive because they set of our armv7 contamination checker.

The first issue I ran into was that "--host arm-linux-gnueabihf" which was passed by the debian packaging when building on armhf results in an armv7 build. Some may argue over whether such behaviour is a bug but it isn't the subject of this bug.

After some testing and configure script reading I deduced that "--host armv6-unknown-linux-gnueabihf" was what was needed to do an armv6 hardfloat build. I modified the packaging, built the package and ran it through the contamination checker and it failed again. Further investigation revealed that -DMODEL_armv6 was being passed for the build of arm.o arm.p.o. I enquired on irc about whether this was deliberate or an oversight and was advised it was probablly an oversight.

So after a little digging in the build system I added the -DMODEL to the rule for building .p.o files from .S files and built again. This time it came out clean so I uploaded to raspbian.

A debdiff of what I uploaded to raspbian can be found at http://debdiffs.raspbian.org/main/o/ocaml/ocaml_4.01.0-3%2brpi1.debdiff

P.S. I am not an ocaml programmer.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Dec 16, 2013

Comment author: @damiendoligez

Extracted and uploaded the part of the patch that applies to our sources.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jun 10, 2014

Comment author: @xavierleroy

This was an oversight, indeed. Thanks for the patch. Committed in 4.02 (r14978) and on trunk (r14979).

@vicuna vicuna closed this Dec 11, 2015

@vicuna vicuna added this to the 4.02.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.