Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think isprintf is missing from the Printf module of the stdlib #6286

Open
vicuna opened this issue Jan 6, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Jan 6, 2014

Original bug ID: 6286
Reporter: berenger
Status: acknowledged (set by @damiendoligez on 2014-07-16T12:51:53Z)
Resolution: open
Priority: normal
Severity: feature
Category: standard library
Tags: patch, junior_job
Related to: #6017
Monitored by: @gasche @ygrek

Bug description

For the sake of completeness, several printers in the
Printf module don't have an i-equivalent
(that does not print anything but is useful to ignore some material when conditionally printing).

While working on a lazy logger, I was in need of the isprintf.

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 22, 2014

Comment author: fabien

Here is a patch for the module printf and the module format.

Some remaining points:

  • I didn't know what "@SInCE version" I should put in the mli
  • I didn't add i-equivalent functions for the deprecated ones in format
  • I didn't add tests in tformat because the only one present was for the deprecated bprintf
  • how should printf behave with malformed format ?
@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 23, 2014

Comment author: fabien

I've attached a new patch that contains more tests (ibprintf) (the former one can be deleted).
I did not add tests for the continuation printf because I don't know what to do.
Any suggestions would be welcome.

Edit: Please use printf_more_tests2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.