Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Build failure with latest version of xcode on OSX #6346
Original bug ID: 6346
It seems that the latest version of clang does not accept the
AFAIK, this flag was never supported by clang and now it makes clang to fail. So I think it is better to just remove it when using clang.
I did a small patch to fix this on OSX. As gcc is now a symlink to clang by default, the configure script looks at the output of "$bytecc --version" to check whether it is clang or not.
Comment author: @xavierleroy
It is quite possible that -fno-defer-pop is not needed for GCC either. I put this flag a long time ago (in the 1990's) because some versions of GCC (1.xx) would otherwise miscompile the computed goto's in byterun/interp.c. So, with appropriate retesting on x86-32 bits (the platform where the defer-pop optimization matters), it might be possible to get rid of -fno-defer-pop entirely.
Comment author: @diml
I also tested with an older version of gcc (3.4.0) and I also get the same result: same ocamlrun file produced with and without -fno-defer-pop.
Should we do more testing (with older versions of gcc) or should we consider that it is safe to remove -fno-defer-pop?
Comment author: @garrigue
I got tired of fixing it by hand every time I reconfigured, and just removed the no-defer-pop on entirely on Darwin.