Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"with module" may introduce module alias in signature, this breaks Coq #6365

Closed
vicuna opened this Issue Apr 9, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

commented Apr 9, 2014

Original bug ID: 6365
Reporter: @garrigue
Assigned to: @garrigue
Status: closed (set by @xavierleroy on 2015-12-11T18:26:35Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.0+dev
Target version: 4.02.0+dev
Fixed in version: 4.02.0+dev
Category: typing
Related to: #5514

Bug description

When N is a module alias, the construction "S with module M = N" introduces this alias in the resulting signature.
As a result compilation of the trunk version of coq is broken.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 9, 2014

Comment author: @garrigue

Fixed in typemod.ml, by applying Mtype.remove_alias to the inserted signature.

Note that this is related to 5514: the official semantics is not to insert the signature of the right-hand side of the equation, but just add equations to the contained types.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2014

Comment author: @whitequark

@garrigue: the patch broke camlp4 build, see PR6371

@vicuna vicuna closed this Dec 11, 2015

@vicuna vicuna added the typing label Mar 14, 2019

@vicuna vicuna added this to the 4.02.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.