Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github patch] new primitive caml_alloc_dummy_function #6393

Closed
vicuna opened this issue May 3, 2014 · 5 comments
Closed

[github patch] new primitive caml_alloc_dummy_function #6393

vicuna opened this issue May 3, 2014 · 5 comments
Milestone

Comments

@vicuna
Copy link

@vicuna vicuna commented May 3, 2014

Original bug ID: 6393
Reporter: @gasche
Status: closed (set by @damiendoligez on 2015-07-20T14:04:37Z)
Resolution: fixed
Priority: normal
Severity: feature
Target version: 4.02.3+dev
Fixed in version: 4.02.3+dev
Category: back end (clambda to assembly)
Tags: github, patch
Monitored by: @bobzhang

Bug description

#37

(Patch by Hugo Heuzard)

caml_alloc_dummy_function takes the function arity as a second argument.
This new information can be used by js_of_ocaml to perform better optimization.

@vicuna
Copy link
Author

@vicuna vicuna commented May 30, 2014

Comment author: @mshinwell

I think this has missed the feature freeze for 4.02.

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 9, 2015

Comment author: @alainfrisch

According to Github, this has been merged to trunk. @gasche: can you confirm and close the ticket?

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 9, 2015

Comment author: @gasche

Yeah, git log -u -S caml_alloc_dummy_function shows that this was trunk@15592 in November 2014. This is not in the 4.02 branch -- so not in the last minor release.

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 17, 2015

Comment author: @damiendoligez

Reopening to include in 4.02.3.

@vicuna
Copy link
Author

@vicuna vicuna commented Jul 20, 2015

Comment author: @damiendoligez

Patch applied to 4.02 (rev 16222).

@vicuna vicuna closed this Jul 20, 2015
@vicuna vicuna added the back-end label Mar 14, 2019
@vicuna vicuna added this to the 4.02.3 milestone Mar 14, 2019
@vicuna vicuna added the feature-wish label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant