Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token += can no longer be used in expression #6397

Closed
vicuna opened this Issue May 6, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented May 6, 2014

Original bug ID: 6397
Reporter: gmelquiond
Assigned to: @lpw25
Status: closed (set by @xavierleroy on 2015-12-11T18:26:49Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.02.0+dev
Category: ~DO NOT USE (was: OCaml general)

Bug description

With the trunk version, the following code no longer compiles.

let (+=) a b = ()
let f a b = a += b

I understand that token += is now used for open types, but I am not sure if the syntax change for expressions is intended or just an oversight. If the former, I suggest to document it (sorry if it is and I missed it). This issue was reported to us since it breaks the compilation of Why3 for some users.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 6, 2014

Comment author: @lpw25

Oops, I missed a case in the parser. The attached patch fixes it. Could someone merge this and mark as resolved?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 6, 2014

Comment author: @gasche

Merged, thanks for the report and the fix reactivity!

@vicuna vicuna closed this Dec 11, 2015

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.