Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in @deprecated text in stdlib/arrayLabels.mli #6436

Closed
vicuna opened this issue May 21, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented May 21, 2014

Original bug ID: 6436
Reporter: @johnwhitington
Assigned to: @damiendoligez
Status: closed (set by @xavierleroy on 2015-12-11T18:27:37Z)
Resolution: fixed
Priority: normal
Severity: text
Fixed in version: 4.02.0+dev
Category: documentation

Bug description

Patch against trunk attached.

I thought about adding [@@ocaml.deprecated] too, but that appears to not be used in every place @deprecated is used in the stdlib .mli files. Would you like a patch for that too?

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented May 21, 2014

Comment author: @damiendoligez

Thanks for the patch. I've applied it to 4.02 (commit 14899).

I thought about adding [@@ocaml.deprecated] too, but that appears to not be used in every place @deprecated is used in the stdlib .mli files. Would you like a patch for that too?

It's a good idea in principle, but I'm sure there will be special cases that need to be discussed, so a systematic patch will probably not be applied as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.