Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github patch] add -linkall flag to ocamlcommon archives #6509

Closed
vicuna opened this Issue Aug 6, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Aug 6, 2014

Original bug ID: 6509
Reporter: @gasche
Assigned to: @gasche
Status: resolved (set by @gasche on 2014-08-06T11:51:35Z)
Resolution: fixed
Priority: low
Severity: tweak
Version: 4.02.0+dev
Target version: 4.02.0+dev
Category: ~DO NOT USE (was: OCaml general)
Related to: #7271

Bug description

A patch by Frédéric Bour:
#53

This patch add the "-linkall" flag when creating the ocamlcommon.cma
and ocamlcommon.cmxa archives.

Modules in "typing/" subdirectory rely on side-effects during
initialization to setup forward references. It would be unsafe for
a module to not be linked, thus it seems preferable to enforce linking
of all modules.

File attachments

@vicuna vicuna closed this Aug 6, 2014

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Aug 6, 2014

Comment author: @gasche

We re-discussed this patch recently: it's not terribly satisfying, but there is no clear better way to do, so it was decided to include it. In the future, it would be nice to have a way to record such forward-dependencies, that the linker could understand to fail if the forward-depended file is not passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.