Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -bin-annot when -packing #6599

Closed
vicuna opened this issue Oct 6, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Oct 6, 2014

Original bug ID: 6599
Reporter: madroach
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2016-12-07T10:36:48Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Monitored by: @hcarty

Bug description

the bin_annot flag is only effective when compiling. It should be enabled when packing, too.
Patch is in "Additional Information".

Additional information

--- ocamlbuild/ocaml_specific.ml.orig Mon Oct 6 06:42:27 2014
+++ ocamlbuild/ocaml_specific.ml Mon Oct 6 06:42:31 2014
@@ -669,6 +669,7 @@ flag ["ocaml"; "link"; "byte"; "output_obj"] (A"-outpu
flag ["ocaml"; "dtypes"; "compile"] (A "-dtypes");;
flag ["ocaml"; "annot"; "compile"] (A "-annot");;
flag ["ocaml"; "bin_annot"; "compile"] (A "-bin-annot");;
+flag ["ocaml"; "bin_annot"; "pack"] (A "-bin-annot");;
flag ["ocaml"; "safe_string"; "compile"] (A "-safe-string");;
flag ["ocaml"; "safe_string"; "infer_interface"] (A "-safe-string");;
flag ["ocaml"; "unsafe_string"; "compile"] (A "-unsafe-string");;

@vicuna

This comment has been minimized.

Copy link
Author

commented Oct 7, 2014

Comment author: @gasche

Merged in 4.02, thanks!

@vicuna

This comment has been minimized.

Copy link
Author

commented Oct 11, 2014

Comment author: @avsm

Isn't the same patch also needed for "annot" as well?

@vicuna

This comment has been minimized.

Copy link
Author

commented Oct 11, 2014

Comment author: @gasche

I tried to review other flags for related mistakes when I applied the patch, but I'll admit that I'm a bit lost at the semantics of some of the flags when packing. It cannot hurt to apply defensively, so I'll add "annot" just in case; feel free to suggest any other likely candidate.

@vicuna

This comment has been minimized.

Copy link
Author

commented Oct 11, 2014

Comment author: madroach

I tested and -pack -annot does not produce .annot files. This might be a missing feature. But adding -annot to -pack doesn't hurt either.

@vicuna

This comment has been minimized.

Copy link
Author

commented Oct 14, 2014

Comment author: @trefis

You can probably close #6178 then.

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added the ocamlbuild label Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.