Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advertise caml_strdup in 19.10.2 instead of strcpy #6601

Closed
vicuna opened this issue Oct 7, 2014 · 3 comments
Closed

advertise caml_strdup in 19.10.2 instead of strcpy #6601

vicuna opened this issue Oct 7, 2014 · 3 comments

Comments

@vicuna
Copy link

@vicuna vicuna commented Oct 7, 2014

Original bug ID: 6601
Reporter: madroach
Status: resolved (set by @damiendoligez on 2017-04-10T13:04:45Z)
Resolution: fixed
Priority: normal
Severity: tweak
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: documentation
Tags: junior_job
Monitored by: @whitequark @gasche @hcarty

Bug description

Since 4.02 OCaml provides ocaml_strdup to get rid of unsafe strcpy calls.
So please don't recommend strcpy in the manual anymore. (first code example in 19.10.2)

@vicuna
Copy link
Author

@vicuna vicuna commented Apr 14, 2016

Comment author: @damiendoligez

I've updated the example. Keeping this PR open because we need to document caml_strdup and caml_strconcat.

[edit] the updating was commits 9d040c2 (in 4.03) and 380a091 (in trunk/4.04)

@vicuna
Copy link
Author

@vicuna vicuna commented Mar 29, 2017

Comment author: @murmour

caml_stat_strdup and caml_stat_strconcat are now documented in memory.h. I've also added a couple of fixes to the manual: #1126.

@vicuna
Copy link
Author

@vicuna vicuna commented Apr 10, 2017

Comment author: @damiendoligez

Fixed by commit 3f705ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant