Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlbuild should pass -linkpkg together with -output-obj #6625

Closed
vicuna opened this Issue Oct 23, 2014 · 4 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

vicuna commented Oct 23, 2014

Original bug ID: 6625
Reporter: @whitequark
Assigned to: @whitequark
Status: closed (set by @xavierleroy on 2016-12-07T10:47:17Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.02.2+dev / +rc1
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Tags: patch
Related to: #6797
Monitored by: @gasche

Bug description

E.g. using this rule:

  flag ["ocaml"; "link"; "output_obj"] &
    A"-linkpkg";

Otherwise, if you use any -package's, ocamlc/ocamlopt will complain of not being able to find implementations.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Dec 19, 2014

Comment author: @whitequark

gasche, can you please apply the trivial fix contained in this issue?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Dec 19, 2014

Comment author: @whitequark

Attached patch properly checks -use-ocamlfind.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Dec 21, 2014

Comment author: @gasche

Merged in 4.02 and trunk.

Do you know about ocamlbuild/testsuite? It is really convenient to write test against in my experience. For using it, my workflow is to "opam compiler-conf reinstall" and then run the tests from the toplevel. I hope you keep contributing features to ocamlbuild lately; you should consider writing small tests to validate that they work as expected.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Dec 21, 2014

Comment author: @whitequark

I did not. I've looked into it and I could not find a non-terrible way to test that -linkpkg is indeed passed. The object file would be built successfully whether it is passed or not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.