Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlmklib should support more options (-g, &c) #6641

Closed
vicuna opened this issue Nov 2, 2014 · 8 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Nov 2, 2014

Original bug ID: 6641
Reporter: @whitequark
Assigned to: @whitequark
Status: closed (set by @xavierleroy on 2016-12-07T10:47:01Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche @ygrek @hcarty

Bug description

I'd like to see these:

  • -g
  • an option that's passed to ocamlc -c / ocamlopt -c

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 19, 2014

Comment author: @whitequark

@gasche, I wrote a patch, can you please take a look?

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 19, 2014

Comment author: @gasche

It seems that the -foo-opt options are new in the standard distribution (ocamlbuild has -cflags, -lflags etc. for what you would call "-compile-opt" and "-link-opt", is there a reason to choose "opt" which may conflict with "the native version" rather than "flag"?). If they are indeed new, I wouldn't include them without running them through our command-line aesthete, that is Damien.

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 19, 2014

Comment author: @whitequark

I have no objections to rename the options. Do you have a better suggestion? Nothing immediately comes to my mind.

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 19, 2014

Comment author: @whitequark

Perhaps -cflags and -optflags?

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 22, 2014

Comment author: @damiendoligez

The consistent (with -ccopt) naming would be "-ocamlcopt" and "-ocamloptopt" but that's too weird.

I'd go for -ocamlcflags and -ocamloptflags, but if you think that's too heavy I won't object to -cflags and -optflags.

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 22, 2014

Comment author: @gasche

I like -ocaml{c,opt}flags.

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 22, 2014

Comment author: @whitequark

Patch updated with -ocaml{c,opt}flags.

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 27, 2014

Comment author: @gasche

Merged in trunk and 4.02.

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.