Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_module should indicate its elision #6648

Closed
vicuna opened this Issue Nov 7, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Nov 7, 2014

Original bug ID: 6648
Reporter: @lpw25
Assigned to: @garrigue
Status: closed (set by @xavierleroy on 2016-12-07T10:36:53Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.03.0+dev / +beta1
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche @hcarty

Bug description

The show_module directive does not fully print the types of nested modules. This is reasonable, but it also does not indicate that it has left out anything which is confusing. For example:

# module M = struct module N = struct let x = 1 end end;;
module M : sig module N : sig val x : int end end

# #show_module M;;
module M : sig module N : sig  end end

Here the x value is simply left out of the type, with no indication that there was anything there.

It should probably print ... or similar whenever something has been left out. So the above would be:

# #show_module M;;
module M : sig module N : sig ... end end
@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Nov 10, 2014

Comment author: @garrigue

Fixed in trunk at revision 15573.
(Do not fix in 4.02 as we need to modify outcometree.)

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.