Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-compiler: version check not working on OS X #6658

Closed
vicuna opened this Issue Nov 14, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

commented Nov 14, 2014

Original bug ID: 6658
Reporter: gerd
Assigned to: @damiendoligez
Status: closed (set by @damiendoligez on 2015-04-02T04:02:31Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.2+dev / +rc1
Category: ~DO NOT USE (was: OCaml general)
Tags: patch
Monitored by: @gasche

Bug description

This is in the configure script: The sed script

ocaml_source_version=sed -n '1 s/\([0-9\.]\+\).*/\1/ p' < ../../VERSION

does not work on OSX, outputs always the empty string. Correct is:

ocaml_source_version=sed -n -e '1 s/\([0-9.]*\).*/\1/ p' < ../../VERSION

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 14, 2014

Comment author: gerd

In the line before, ocaml_system_version should be changed to

ocaml_system_version=ocamlrun -version | sed 's/[^0-9]*\([0-9.]*\).*/\1/'

(also replacing * for +)-

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 21, 2014

Comment author: @whitequark

@gasche, can you please apply the trivial fix listed in the issue?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 22, 2014

Comment author: @damiendoligez

This one is on MacOS, so it's for me rather than @gasche.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 2, 2015

Comment author: @damiendoligez

Fixed in branch 4.02 (rev 15981). Thanks for the report and for the patch.

@vicuna vicuna closed this Apr 2, 2015

@vicuna vicuna added this to the 4.02.2 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.