You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@gasche, I added a patch. It adds the .so targets, and also a runtime_variant parametric flag.
The flag is needed on, I think, mainly x86, where all code in a shared library must be linked with -fPIC. On e.g. ARM, there is no such restriction.
Until #6693 is fixed, the ocamlbuild testsuite will fail (on x86, at least).
I did not add a runtime_variant(_shared) flag to the default tags for .so targets, because:
tags++"runtime_variant(x)" doesn't seem to do anything;
the _shared variant of the tag is probably not what most users of the .so targets want, as libcamlrun_shared.so is not even in default library search path.
I think it is OK to leave the default tags as-is, or if there will be a _pic variant of the runtime--a .a archive built with -fPIC--we could add runtime_variant(_pic) so that everything builds by default on all platforms. Having to manually specify "-runtime_variant(_pic), runtime_variant(_some_other)" is a bit awkward, but should be rarely needed.