Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: virtual_flag in typedtree is duplicated. #6742

Closed
vicuna opened this Issue Jan 5, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

commented Jan 5, 2015

Original bug ID: 6742
Reporter: @Drup
Assigned to: @garrigue
Status: closed (set by @xavierleroy on 2016-12-07T10:47:05Z)
Resolution: fixed
Severity: minor
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.03.0+dev / +beta1
Category: typing
Monitored by: @gasche

Bug description

In the typedtree, we have the following definition:

| Tstr_class of (class_declaration * string list * virtual_flag) list

However, class_declaration = class_expr class_infos and class_infos has a field ci_virt containing the virtual flag.

After a bit of investigation, class_infos seems to have been introduced much later than the virtual flag in Tstr_class. In the code, they seem to be equal (but obtained by different means). Is it really the case, and if no, why ?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2015

Comment author: @garrigue

Well spotted.
Removed this duplicate information in trunk, at revision 15776.

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added the typing label Mar 14, 2019

@vicuna vicuna added this to the 4.03.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.