Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional values in cmt files #6748

Closed
vicuna opened this Issue Jan 12, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

commented Jan 12, 2015

Original bug ID: 6748
Reporter: @chambart
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2016-12-07T10:47:05Z)
Resolution: fixed
Priority: normal
Severity: crash
Version: 4.03.0+dev / +beta1
Target version: 4.03.0+dev / +beta1
Fixed in version: 4.03.0+dev / +beta1
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @gasche

Bug description

When building this file with -bin-annot, the compiler raises:

Fatal error: exception Invalid_argument("output_value: functional value")

This was introduced by the commit: 9d450a0
( Replace TypedtreeMap with a more standard open-recursion iterator Tast_mapper. Keep TypedtreeMap/Iter for now, for external projects. )

module M = struct
external init: unit -> unit = "some_stub"
end

module type T =
sig
val init : unit -> unit
end

let m = (module M:T)

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 12, 2015

Comment author: @gasche

We need a cmt-producing entry in the testsuite to catch such regressions earlier.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 13, 2015

Comment author: @damiendoligez

Why don't we build the whole system with -bin-annot by default?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 15, 2015

Comment author: @alainfrisch

Well spotted. Thanks for the minimal repro case. Fixed in commit 15773.

Why don't we build the whole system with -bin-annot by default?

Isn't it already the case? But compiling the compiler doesn't exercise all code paths in the compiler (in tast_iter for the current ticket).

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added this to the 4.03.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.