Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of Bigarray.Genarray.map_file #6810

Closed
vicuna opened this issue Mar 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Mar 11, 2015

Original bug ID: 6810
Reporter: @dbuenzli
Assigned to: @mshinwell
Status: closed (set by @xavierleroy on 2016-12-07T10:49:16Z)
Resolution: fixed
Priority: normal
Severity: trivial
Version: 4.02.1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.2+dev / +rc1
Category: documentation
Tags: junior_job
Monitored by: @hcarty

Bug description

It should mention that the function raises Sys_error in case of error.

@vicuna

This comment has been minimized.

Copy link
Author

commented Mar 11, 2015

Comment author: @dbuenzli

(had to check the sources was wondering if maybe it was raising Unix.Error)

@vicuna

This comment has been minimized.

Copy link
Author

commented May 6, 2015

Comment author: @mshinwell

It looks like it can raise Invalid_argument or Failure, as well as Sys_error. However it appears that an error arising from a failure to map (or some other system call that is used) is always reported as Sys_error. The remainder arise from validation of arguments.

@vicuna

This comment has been minimized.

Copy link
Author

commented May 6, 2015

Comment author: @mshinwell

Fixed in 4.02

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added this to the 4.02.2 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.