Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/ucontext.h present in current Android NDK #6830

Closed
vicuna opened this Issue Apr 3, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Apr 3, 2015

Original bug ID: 6830
Reporter: @psteckler
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2016-12-07T10:47:28Z)
Resolution: duplicate
Priority: normal
Severity: minor
Platform: x86_64
OS: Fedora
OS Version: 21
Version: 4.02.1
Fixed in version: 4.02.2+dev / +rc1
Category: runtime system and C interface
Duplicate of: #6617

Bug description

In asmrun/signals_osdep.h, there is an #ifdef for Android to create a type
definition for ucontext because, as the comment states, sys/ucontext.h is not
present in the Android NDK.

When compiling ocaml-android (I know, not an official project), I get an error
message about a duplicate type definition for ucontext.

That's because Android NDK r10d does have sys/ucontext.h these days. Removing
the #ifdef allows compilation to proceed. That #ifdef should be removed from the sources.

Steps to reproduce

install Android NDK r10d
git clone https://github.com/vouillon/ocaml-android.git
download OCaml 4.02.1 sources, unpack them
edit Makefile.config in ocaml-android with locations for Android NDK, OCaml sources
make

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 4, 2015

Comment author: @gasche

This is a good catch, but I think it was already done in #6617 -- the change will be available in the next OCaml release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.