Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build breaks for -aspp gcc on solaris-like OSs #6831

Closed
vicuna opened this issue Apr 6, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Apr 6, 2015

Original bug ID: 6831
Reporter: JT
Status: closed (set by @damiendoligez on 2015-04-29T16:46:08Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: i386
OS: solaris
Version: 4.02.1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.2+dev / +rc1
Category: configure and build/install

Bug description

illumos/Solaris systems generally include their own as with a functioning preprocessed flag (/usr/ccs/bin/as -P).
SmartOS, however, does not include this binary and so requires using GCC.

This breaks in asmrun/i386.S where it expects all solaris systems to use the same as.

The solution is check that it is both a solaris system and that we're not using GCC for the affected piece of code.

Steps to reproduce

On SmartOS:
./configure -aspp "gcc -c" && make world opt

Additional information

Patch checked using make world opt opt.opt on:
OpenIndiana a9 and hipster which uses /usr/ccs/bin/as -P
SmartOS using gcc -c

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented Apr 29, 2015

Comment author: @damiendoligez

Thanks for the patch. I applied it to branch 4.02 (rev 16055).

@vicuna vicuna closed this Apr 29, 2015

@vicuna vicuna added this to the 4.02.2 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.