Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries with profiling information are not built on FreeBSD amd64 #6837

Closed
vicuna opened this issue Apr 10, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Apr 10, 2015

Original bug ID: 6837
Reporter: michi
Assigned to: @mshinwell
Status: closed (set by @xavierleroy on 2016-12-07T10:49:14Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: amd64
OS: FreeBSD
OS Version: 10.1
Version: 4.02.1
Target version: 4.02.2+dev / +rc1
Fixed in version: 4.02.2+dev / +rc1
Category: platform support (windows, cross-compilation, etc)

Bug description

Is there any reason why libraries with profiling information are not built on FreeBSD amd64, while being built on FreeBSD i386?

It seems to me that this is an error, as gprof is definitely available on that
platform.

I do not really understand the following logic to detect profiling
support.

----8<----
cc_profile='-pg'
case "$arch,$system" in
i386,linux_elf) profiling='prof';;
i386,gnu) profiling='prof';;
i386,bsd_elf) profiling='prof';;
amd64,macosx) profiling='prof';;
...
---->8-----

Wouldn't be easier, clearer and less error-prone to check for a gprof
program? Or am I missing something?

@vicuna

This comment has been minimized.

Copy link
Author

commented May 6, 2015

Comment author: @mshinwell

Well, you might not necessarily have the profiling tools installed on your build machine, e.g. some kind of compile farm.

For the moment it seems to suffice to add amd64/freebsd to the list. I also added amd64/netbsd. Committed to 4.02.

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added this to the 4.02.2 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.